Add cJSON dependency to Tab5 platform#132
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| espressif/esp_lcd_ili9881c: ^1.0.1 | ||
| cjson: '*' |
There was a problem hiding this comment.
[P1] Resolve cJSON dependency with proper namespace
The manifest lists the new dependency as cjson: '*', but the component manager expects registry components to be fully qualified (e.g. espressif/cjson). With the current key there is no local component named cjson, so idf.py build will fail when the manager attempts to resolve this dependency. Keep the CMake REQUIRES cjson entry, but change the manifest to reference espressif/cjson (or drop the entry entirely if relying on the built‑in IDF component).
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Summary
- Updated the Tab5 platform manifest to reference the cJSON dependency via the fully qualified
espressif/cjsonnamespace so the component manager can resolve it correctly. platforms/tab5/main/idf_component.ymlL1-L25
Testing
⚠️ idf.py lint(fails: command not found: idf.py in container environment)
1 participant
Summary
Testing
idf.py build(fails: command not found: idf.py in container environment)https://chatgpt.com/codex/tasks/task_e_68ce4d69e7dc8324b467e13f9ed471bc